-
Notifications
You must be signed in to change notification settings - Fork 112
Start using the refreshVersions Gradle plugin to manage dependencies. #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rjrjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is great.
build.gradle.kts
Outdated
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| //import de.fayard.OrderBy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Planning to delete here and below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, i still want to try to get this working so we don't have to keep manually sorting that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted instead, don't want to fight with gradle more than absolutely necessary today.
| ## suppress inspection "SpellCheckingInspection" for whole file | ||
| ## | ||
| ## Dependencies and Plugin versions with their available updates | ||
| ## Generated by $ ./gradlew refreshVersions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of control do we have when there are specific versions we don't want to bump? I guess we just don't use the _?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. But the tooling is very safe – you run ./gradlew refreshVersions, and it just adds a bunch of comments to that file telling you what the latest versions are. You have to actually edit it to update.
https://github.com/jmfayard/refreshVersions This change migrates dependency versions to the versions.properties file, which will be resolved into actual dependency strings by the plugin. New versions can be checked for by running `./gradlew refreshVersions`. Note that **this commit does not change any version numbers**, it simply moves them to be defined in a different location. It also deletes some stale dependency definitions that weren't actually used.
ecf88a8 to
912a40e
Compare
|
UI test failed with #88: |
|
Failure was a cache failure, merging. |
https://github.com/jmfayard/refreshVersions
This change migrates dependency versions to the versions.properties file,
which will be resolved into actual dependency strings by the plugin. New
versions can be checked for by running
./gradlew refreshVersions.Note that this commit does not change any version numbers, it simply
moves them to be defined in a different location. It also deletes some
stale dependency definitions that weren't actually used.
Prep for #51.