Skip to content

Conversation

@zach-klippenstein
Copy link
Collaborator

@zach-klippenstein zach-klippenstein commented Jul 10, 2020

https://github.com/jmfayard/refreshVersions

This change migrates dependency versions to the versions.properties file,
which will be resolved into actual dependency strings by the plugin. New
versions can be checked for by running ./gradlew refreshVersions.

Note that this commit does not change any version numbers, it simply
moves them to be defined in a different location. It also deletes some
stale dependency definitions that weren't actually used.

Prep for #51.

@zach-klippenstein zach-klippenstein requested a review from a team as a code owner July 10, 2020 17:58
Copy link
Collaborator

@rjrjr rjrjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is great.

build.gradle.kts Outdated
* See the License for the specific language governing permissions and
* limitations under the License.
*/
//import de.fayard.OrderBy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning to delete here and below?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i still want to try to get this working so we don't have to keep manually sorting that file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted instead, don't want to fight with gradle more than absolutely necessary today.

## suppress inspection "SpellCheckingInspection" for whole file
##
## Dependencies and Plugin versions with their available updates
## Generated by $ ./gradlew refreshVersions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of control do we have when there are specific versions we don't want to bump? I guess we just don't use the _?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. But the tooling is very safe – you run ./gradlew refreshVersions, and it just adds a bunch of comments to that file telling you what the latest versions are. You have to actually edit it to update.

https://github.com/jmfayard/refreshVersions

This change migrates dependency versions to the versions.properties file,
which will be resolved into actual dependency strings by the plugin. New
versions can be checked for by running `./gradlew refreshVersions`.

Note that **this commit does not change any version numbers**, it simply
moves them to be defined in a different location. It also deletes some
stale dependency definitions that weren't actually used.
@zach-klippenstein
Copy link
Collaborator Author

UI test failed with #88:

com.squareup.sample.TicTacToeEspressoTest > canGoBackInModalView[test(AVD) - 7.0] FAILED 
	kotlin.reflect.jvm.internal.KotlinReflectionInternalError: Introspecting local functions, lambdas, anonymous functions and local variables is not yet fully supported in Kotlin reflection
	at kotlin.reflect.jvm.internal.EmptyContainerForLocal.fail(EmptyContainerForLocal.kt:41)
Tests on test(AVD) - 7.0 failed: Instrumentation run failed due to 'Process crashed.'

@zach-klippenstein
Copy link
Collaborator Author

Failure was a cache failure, merging.

@zach-klippenstein zach-klippenstein merged commit 53bd488 into main Jul 10, 2020
@zach-klippenstein zach-klippenstein deleted the zachklipp/dependencies branch July 10, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants