Skip to content

Conversation

@sssurvey
Copy link
Contributor

@sssurvey sssurvey commented Jul 2, 2023

While going over the sample tutorials. I noticed there is a minor issue in Tutorial4.md.

Quote from the current tutorial:

Because TodoWorkflow.State has no properties anymore, it can't be a data class, so we need to change it to an object. Since the only reason to have a custom type for state is to define the data we want to store, we don't need a custom type anymore so we can just use Unit. You might ask why we need a state at all now. We will discuss that in the next section. For now Unit will get us moving forward.

However, based on the context, it seems that it should be TodoListWorkflow.State instead of TodoWorkflow.State. (In this tutorial, we are refactoring TodoListWorkflow by introducing a new TodoWorkflow)

@sssurvey sssurvey requested review from a team and zach-klippenstein as code owners July 2, 2023 16:24
@CLAassistant
Copy link

CLAassistant commented Jul 2, 2023

CLA assistant check
All committers have signed the CLA.

@rjrjr rjrjr merged commit 551ee52 into square:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants