Override setBackground() like we do setVisibility() in WorkflowViewStub. #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Author
|
Ah, I see the workflow-ui/core-android/build/api/core-android.api file needs to be updated for the build to totally pass |
Collaborator
You just need to run |
rjrjr
reviewed
Jul 8, 2020
workflow-ui/core-android/src/main/java/com/squareup/workflow/ui/WorkflowViewStub.kt
Outdated
Show resolved
Hide resolved
zach-klippenstein
approved these changes
Jul 11, 2020
Collaborator
zach-klippenstein
left a comment
zach-klippenstein
left a comment
There was a problem hiding this comment.
LGTM but holding off on merging until @rjrjr has approved the changes.
Collaborator
|
@afollestad I've lost track. Besides rebasing, is this in its final form? |
Member
Author
Yep everything is looking good in SPOS! |
This allows stubs to have a background color, for an example, that also applies to all displayed content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows stubs to have a background color, for an example, that also applies to all displayed content.