GH Actions caching tweaks #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Removed
- don't bother caching/restoring `~/.gradle/wrapper` with `actions/cache/___` steps.
- It's already cached by `gradle/gradle-build-action`
- don't use cross-OS archiving.
- Gradle doesn't seem to like it, even just going between Ubuntu and MacOS.
- remove the `lookup-only` toggle for the initial cache-restore step (default is false).
- The property was left there in error. If we get a cache hit on the `cache-write-key`, we definitely want to download it.
### Added
- make an explicit default of 'null' for cache keys, and check if the value is 'null' in a step's `if` condition instead of just checking whether a value is there.
- The `gradle-task-with-commit` action forwards its keys to this action. Prior to this, if no key was specified when invoking that action, the `gradle-task-with-commit` action passes a key of '' to the `gradle-task` action. The result would be saving and restoring a blank key with who-knows-what in the cache.
- cache every project build directory (`./**/build/**`) since they tend to be quite small
- add the `${{runner.os}}-` prefix to `key` and `restore-keys` arguments.
- Otherwise, caches for MacOS and Ubuntu would have the same keys -- which is bad when cross-OS archiving is disabled.
RBusarow
force-pushed
the
rick/caching_strategies
branch
from
74499d8 to
3f6a188
Compare
rjrjr
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
~/.gradle/wrapperwithactions/cache/___steps.- It's already cached by
gradle/gradle-build-action- Gradle doesn't seem to like it, even just going between Ubuntu and MacOS.
lookup-onlytoggle for the initial cache-restore step (default is false).- The property was left there in error. If we get a cache hit on the
cache-write-key, we definitely want to download it.Added
ifcondition instead of just checking whether a value is there.- The
gradle-task-with-commitaction forwards its keys to this action. Prior to this, if no key was specified when invoking that action, thegradle-task-with-commitaction passes a key of '' to thegradle-taskaction. The result would be saving and restoring a blank key with who-knows-what in the cache../**/build/**) since they tend to be quite small${{runner.os}}-prefix tokeyandrestore-keysarguments.- Otherwise, caches for MacOS and Ubuntu would have the same keys -- which is bad when cross-OS archiving is disabled.