Redundant calls to View.showRendering

[rjrjr]

DecorativeViewFactory makes redundant calls to showRendering, and these can compound. I think the proper fix is to factor a rebindShowRendering call out of bindShowRendering that replaces the function but doesn't call it.

[zach-klippenstein]

I agree this is a problem, I'm not sure I agree with your proposed solution. The root of the issue is the logic in DecoratorViewFactory that actually calls bind twice. Your proposed solution is one way to fix that, but I'm not sure it's the best one. For one, the contrast between bind/rebind doesn't imply to me that one calls showRendering and the other doesn't. For another, it might be better to add better support for the thing that DecoratorViewFactory is ultimately trying to do – I played around with this a few months back, via an API for effectively intercepting the view after it's created and the rendering tag is set but before showRendering is called, which allows the interceptor to decide whether or not to actually call showRendering.

Your solution might actually be simpler, but we should consider the tradeoffs.

[rjrjr]

I think this is a "why not both" situation. DecorativeViewFactory def. needs some love (e.g. #396), and separating the two inappropriately coupled concerns in bindShowRendering will make it easier to improve. We can come up with better names than bind and rebind -- perhaps View.initialize is the new name for bindShowRendering.

Note to self, here's the previous attempt: #276

[rjrjr]

Really, bindShowRendering was just a mistake. I was worried about people forgetting to make the initial call to showRendering, so I tried to make that impossible and coupled the concerns. This was before WorkflowViewStub, when I expected it to be a lot more common to call these methods directly.