This repository was archived by the owner on Feb 5, 2021. It is now read-only.
Add the ability to display nested renderings with bindCompose. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-klippenstein
force-pushed
the
zachklipp/compose-nesting
branch
4 times, most recently
from
94f16de to
7b16503
Compare
core-compose/src/main/java/com/squareup/workflow/ui/compose/ViewFactories.kt
Outdated
Show resolved
Hide resolved
core-compose/src/main/java/com/squareup/workflow/ui/compose/ViewFactories.kt
Show resolved
Hide resolved
| * | ||
| * See [this slack message](https://kotlinlang.slack.com/archives/CJLTWPH7S/p1576264533012000?thread_ts=1576262311.008800&cid=CJLTWPH7S). | ||
| */ | ||
| private class ComposableViewStubWrapper(context: Context) : FrameLayout(context) { |
Collaborator
Author
There was a problem hiding this comment.
Nit: Might be a simpler way to do this using a WVS directly with a Ref, so we could get rid of this class altogether. Will probably explore as a follow up though, right now hosting legacy views in Composables is not fully supported by compose anyway.
Collaborator
Author
There was a problem hiding this comment.
Tried this, didn't work. I think it has something to do with LayoutParams not getting set correctly.
zach-klippenstein
force-pushed
the
zachklipp/compose-nesting
branch
from
7b16503 to
62ce98e
Compare
Collaborator
Author
|
Made the sample demonstrate dipping back into legacy views as well, and fixed a layout issue with legacy views. |
rjrjr
reviewed
May 13, 2020
rjrjr
reviewed
May 13, 2020
core-compose/src/main/java/com/squareup/workflow/ui/compose/ComposeViewFactory.kt
Outdated
Show resolved
Hide resolved
rjrjr
approved these changes
May 13, 2020
zach-klippenstein
force-pushed
the
zachklipp/compose-nesting
branch
2 times, most recently
from
62ce98e to
308dbd5
Compare
Comment on lines
+61
to
+70
| * Workflows can render other workflows, and renderings from one workflow can contain renderings | ||
| * from other workflows. These renderings may all be bound to their own [ViewFactory]s. Regular | ||
| * [ViewFactory]s and `LayoutRunner`s use | ||
| * [WorkflowViewStub][com.squareup.workflow.ui.WorkflowViewStub] to recursively show nested | ||
| * renderings using the [ViewRegistry][com.squareup.workflow.ui.ViewRegistry]. | ||
| * | ||
| * View factories defined using this function may also show nested renderings. Doing so is as simple | ||
| * as calling [ViewEnvironment.showRendering] and passing in the nested rendering. See the kdoc on | ||
| * that function for an example. |
This is the Compose analog to `WorkflowViewStub`, and delegates to `WorkflowViewStub` except when the child `ViewFactory` was also created with `bindCompose`. In that case, it just invokes that factory's Composable function directly to avoid jumping back out into legacy View land.
zach-klippenstein
force-pushed
the
zachklipp/compose-nesting
branch
from
308dbd5 to
430d476
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Compose analog to
WorkflowViewStub, and delegates toWorkflowViewStubexcept when the childViewFactorywas also createdwith
bindCompose. In that case, it just invokes that factory'sComposable function directly to avoid jumping back out into legacy
View land.
The API is really simple:
Includes a sample that demonstrates drawing recursive composable bindings:
