Skip to content

[Python] Establish database connection from data source name #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2019
Merged

[Python] Establish database connection from data source name #813

merged 2 commits into from
Sep 16, 2019

Conversation

@tonyyang-svail
Copy link
Collaborator

@tonyyang-svail tonyyang-svail commented Sep 12, 2019

Fix #806.

weiguoz
weiguoz approved these changes Sep 16, 2019
View reviewed changes
Copy link
Collaborator

@weiguoz weiguoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tonyyang-svail tonyyang-svail merged commit f627330 into sql-machine-learning:develop Sep 16, 2019
@tonyyang-svail tonyyang-svail deleted the fix_806 branch September 16, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiguoz weiguoz weiguoz approved these changes

@Yancey0623 Yancey0623 Awaiting requested review from Yancey0623

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Generate Python database connector from data source string

2 participants

@tonyyang-svail @weiguoz