Update test_e2e.sh #783
Merged
Update test_e2e.sh #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please skip the ant-xgbosot uni test in executor_test.go to pass the CI. |
Yancey0623
reviewed
Sep 5, 2019
Collaborator
|
Hi @Yancey1989, would you please file a PR changing the Docker image from |
Collaborator
|
Hi @tonyyang-svail @wangkuiyi , I reopen this PR, and I'm so sorry that I closed this PR as my hands slipped 😂😂 |
Contributor
|
LGTM |
Collaborator
@tonyyang-svail will do that today 😄😄 |
…flow into wangkuiyi-patch-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #784
I would prefer to see that Ant-XGBoost either merges to dmlc/xgboost, or the launcher in Ant-XGBoost being separated out into alipay/automl. It doens't make sense to me to keep a launcher of xgboost in a fork and release the fork under the name
xgboost-launcher.Before the code clean up, I think we shouldn't keep the end-to-end test of Ant-XGBoost in the Travis CI of SQLFlow.