Skip to content

Conversation

@Yancey0623
Copy link
Collaborator

@Yancey0623 Yancey0623 commented Aug 31, 2019

a part work of #758

Copy link
Contributor

@sperlingxx sperlingxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, ant-xgboost is nothing but another wrapper of xgboost. Maybe we just keep the xgboost name rather than change it to ant-xgboost? I'm afraid using ant-xgboost will make user confuse about the difference bewteen ant-xgboost and xgboost, which is unnecessary in respect of users.

@Yancey0623
Copy link
Collaborator Author

Yancey0623 commented Sep 2, 2019

So far, ant-xgboost is nothing but another wrapper of xgboost. Maybe we just keep the xgboost name rather than change it to ant-xgboost? I'm afraid using ant-xgboost will make user confuse about the difference bewteen ant-xgboost and xgboost, which is unnecessary in respect of users.

It seems that ant-xgboost is a forked branch of xgboost , the existing codegen_xgboost.go would generate a Python program which call laucnher module of ant-xgboost instead of the XGBoost Python API.

And ant-xgboost also includes many excellent features such as auto-train, launch the distributed job on k8s/spark with the launcher module. Maybe we need to let users/developers know if they are using xgboost or ant-xgboost.

@sperlingxx sperlingxx self-requested a review September 2, 2019 13:09
@Yancey0623 Yancey0623 merged commit 9f9bba7 into sql-machine-learning:develop Sep 2, 2019
@Yancey0623 Yancey0623 deleted the rename_ant_xgboost branch September 2, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants