Skip to content

simplify expression resolver #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 30, 2019
Merged

simplify expression resolver #722

merged 8 commits into from
Aug 30, 2019

Conversation

@typhoonzero
Copy link
Collaborator

@typhoonzero typhoonzero commented Aug 27, 2019 •
edited
Loading

part of work in #705

@typhoonzero typhoonzero changed the title [WIP] simplify expression resolver simplify expression resolver Aug 29, 2019
Yancey0623
Yancey0623 reviewed Aug 29, 2019
View reviewed changes
Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about creating a sub package sql/columns and move all the *_column.go files into sql/columns.

@typhoonzero
Copy link
Collaborator Author

typhoonzero commented Aug 29, 2019

How about creating a sub package sql/columns and move all the *_column.go files into sql/columns.

Will do that later, since all structs in sql packages is not exported, we must export things in sql.y to let other packages to use.

Yancey0623
Yancey0623 approved these changes Aug 30, 2019
View reviewed changes
Copy link
Collaborator

@Yancey0623 Yancey0623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit fd806cb into sql-machine-learning:develop Aug 30, 2019
@typhoonzero typhoonzero deleted the simplify_expression_resolver branch August 30, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yancey0623 Yancey0623 Yancey0623 approved these changes

@uuleon uuleon Awaiting requested review from uuleon

@tonyyang-svail tonyyang-svail Awaiting requested review from tonyyang-svail

@weiguoz weiguoz Awaiting requested review from weiguoz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@typhoonzero @Yancey0623