xgboostFiller refine #651
Merged
xgboostFiller refine #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sperlingxx
commented
Aug 12, 2019
sperlingxx
commented
- remove unused codes respect to milestone one
- filler completion
- refine specialized codes of train/predict mode
Yancey0623
reviewed
Aug 12, 2019
sql/python/sqlflow_submitter/xgboost/sqlflow_data_source_test.py
Outdated
Show resolved
Hide resolved
sql/codegen_xgboost.go
Outdated
| roughly same as TFEstimator, except output shape of feaColumns are required to be 1-dim. | ||
| */ | ||
| // parseFeatureColumns, parse feature columns from AST(pr.columns). | ||
| // Features columns are columns owned by default column target("feature_columns:). |
There was a problem hiding this comment.
target("feature_columns:). is not a complete schema?
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.