[Intermediate Representation] xgboost predict using IR #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

weiguoz merged 7 commits into sql-machine-learning:develop from Yancey0623:ir_xgboost_pred

Oct 23, 2019

Collaborator

Yancey0623 commented Oct 22, 2019 •

edited

Loading

fixed #1051

Yancey0623 added 2 commits

October 22, 2019 16:15


          refact xgboost predict using ir

106ba30


          update

e721572

Yancey0623 changed the title ~~xgboost predict using IR~~ [IR] xgboost predict using IR

Yancey0623 requested review from tonyyang-svail, typhoonzero and weiguoz

October 22, 2019 08:53

weiguoz reviewed

View reviewed changes

pkg/sql/codegen/xgboost/template_pred.go Show resolved Hide resolved

weiguoz reviewed

View reviewed changes

pkg/sql/executor.go Outdated Show resolved Hide resolved

Yancey0623 added 3 commits

October 22, 2019 20:41


          fix ut

93cc26f


          update

6e7ab88


          fix ut

b90839c

weiguoz reviewed

View reviewed changes

pkg/sql/ir_generator.go Outdated Show resolved Hide resolved

weiguoz reviewed

View reviewed changes

pkg/sql/ir_generator.go Show resolved Hide resolved

weiguoz reviewed

View reviewed changes

pkg/sql/ir_generator.go Outdated Show resolved Hide resolved

tonyyang-svail changed the title ~~[IR] xgboost predict using IR~~ [Intermediate Representation] xgboost predict using IR

tonyyang-svail previously approved these changes

View reviewed changes

Collaborator

tonyyang-svail left a comment

Generally LGMT. Please also refer to the comments by @weiguoz and me for possible improvements.

pkg/sql/ir_generator.go Outdated Show resolved Hide resolved

pkg/sql/executor.go Show resolved Hide resolved

Yancey0623 added 2 commits

October 23, 2019 10:27


          Merge branch 'develop' of github.com:sql-machine-learning/sqlflow int…

3457f32

…o ir_xgboost_pred


          update

0977ec4

Yancey0623 dismissed tonyyang-svail’s stale review via

0977ec4

October 23, 2019 02:48

weiguoz self-requested a review

October 23, 2019 03:22

weiguoz approved these changes

View reviewed changes

Collaborator

weiguoz left a comment

LGTM

weiguoz merged commit 1866be3 into sql-machine-learning:develop

Yancey0623 deleted the ir_xgboost_pred branch

October 23, 2019 05:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet