Use pkg/sql/codegen/attribute in XGBoost TrainIR #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Oct 15, 2019
Collaborator
typhoonzero
left a comment
typhoonzero
left a comment
There was a problem hiding this comment.
merge #1004 (review) first?
Collaborator
Author
Done. |
wangkuiyi
approved these changes
Oct 15, 2019
| return nil | ||
| }, | ||
| func newFloat32(f float32) *float32 { | ||
| return &f |
Collaborator
There was a problem hiding this comment.
I am not sure if returning the address of a parameter is to new a float value. Maybe
return &new(float32)
Collaborator
Author
There was a problem hiding this comment.
Go supports returning address of stack variables: https://stackoverflow.com/questions/52996452/returning-pointer-from-a-local-variable-in-function
shendiaomo
pushed a commit
to shendiaomo/sqlflow
that referenced
this pull request
Oct 22, 2019
…g#1005) * Add attribute value range checker helper function * Use pkg/sql/codegen/attribute in XGBoost TrainIR * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on #1004.
Fix #1002.