Fix trailing whitespace when dumping dicts with indent #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dumping a dict with indent > 0, `dict_to_json` would insert extra trailing whitespace before the opening and closing newlines of the dict. Also, when dumping an empty dict, two newlines would be inserted. This commit fixes both of these issues.
Owner
|
Hi, thanks for the PR. Could you help me with some code to reproduce the problem(s) this fixes? That way I can write a test for it. If not, that's OK, I should get around to it this week in either case. Thanks again! |
Owner
|
This is now released in version 1.1.2 :) |
laomaiweng
added a commit
to laomaiweng/json-five
that referenced
this pull request
Jun 15, 2024
Contributor
Author
|
Thanks for merging this! I just added a test script for these changes, feel free to pull it in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dumping a dict with indent > 0,
dict_to_jsonwould insert extra trailing whitespace before the opening and closing newlines of the dict. Also, when dumping an empty dict, two newlines would be inserted.This PR fixes both of these issues.