Check both SerDe BeanPropertyDefinition for @JsonUnwrapped/@Schema
#2909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpleine
pushed a commit
to mpleine/springdoc-openapi
that referenced
this pull request
May 17, 2025
Check both SerDe `BeanPropertyDefinition` for `@JsonUnwrapped`/`@Schema`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2894 we switched from just looking at the fields for
@JsonUnwrapped/@Schemato relying on Jackson introspection. That however wrongly relied on deserialization view only, which lead to #2879 (comment).In this PR both Serialisation and Deserialization
BeanPropertyDefinitions are introspected.A test covers both readonly and writeonly fields annotated with
@JsonUnwrapped.Fixes #2879 (comment)