Fix SessionCreatedEvent handling in RedisIndexedSessionRepository #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, RedisIndexedSessionRepository publishes a SessionCreatedEvent backed by an empty MapSession instance. This happens because session delta has been cleared before publishing a message to the session created channel. Fixes spring-projectsgh-1338
This commit addresses code warnings due to nullability of return values.
rwinch
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to migrate
RedisIndexedSessionRepositorytoRedisSessionMapperin order to reuse the session mapping logic, I ran into #1338. This problem has been somewhat hidden by the old mapping code being too lenient and accepting a map with no entries at all whereasRedisSessionMappervalidates both map not being empty as well as presence of key session properties.At present,
RedisIndexedSessionRepositorypublishes aSessionCreatedEventbacked by an emptyMapSessioninstance. This happens because session delta has been cleared before publishing a message to the session created channel.Fixes gh-1338