Skip to content

Add Revved up by Gradle Enterprise badge to README #9327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

Add Revved up by Gradle Enterprise badge to README #9327

merged 1 commit into from
Jan 5, 2021

Conversation

@runningcode
Copy link
Contributor

@runningcode runningcode commented Jan 5, 2021

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 5, 2021
@runningcode runningcode force-pushed the no/revved-up-by-ge branch 3 times, most recently from df6ff02 to 760d465 Compare January 5, 2021 16:31
jzheaux
jzheaux requested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @runningcode! I've left some feedback inline.

README.adoc Outdated
Copy link
Contributor

@jzheaux jzheaux Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice for this link to be https://ge.spring.io/scans?search.rootProjectNames=spring-security instead so that it shows spring-security builds by default.

Copy link
Contributor Author

@runningcode runningcode Jan 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent Idea. Done!

@runningcode runningcode requested a review from jzheaux January 5, 2021 17:00
@jzheaux jzheaux self-assigned this Jan 5, 2021
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 5, 2021
@jzheaux jzheaux added this to the 5.5.0-M2 milestone Jan 5, 2021
@jzheaux jzheaux merged commit 6d59b10 into spring-projects:master Jan 5, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jan 5, 2021

Thanks, @runningcode! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels

in: docs An issue in Documentation or samples type: enhancement A general enhancement

Projects

None yet

Milestone

5.5.0-M2

Development

Successfully merging this pull request may close these issues.

3 participants

@runningcode @jzheaux @spring-projects-issues