Skip to content

Enable AuthenticationManager configuration in saml2Login #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2019
Merged

Enable AuthenticationManager configuration in saml2Login #7693

merged 2 commits into from
Dec 17, 2019

Conversation

fhanik
Copy link
Contributor

@fhanik fhanik commented Dec 2, 2019

Allow configuration of AuthenticationManagerResolver in saml2Login()

Fixes gh-7654

@fhanik fhanik added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Dec 2, 2019
@fhanik fhanik requested review from jzheaux and jgrandja December 2, 2019 15:42
@fhanik fhanik self-assigned this Dec 2, 2019
@fhanik fhanik removed the request for review from jgrandja December 2, 2019 16:54
@fhanik fhanik mentioned this pull request Dec 2, 2019
Closed
jzheaux
jzheaux requested changes Dec 2, 2019
View reviewed changes
@fhanik fhanik changed the title Enable AuthenticationManagerResolver in saml2Login Enable AuthenticationProvider configuration in saml2Login Dec 3, 2019
jgrandja
jgrandja requested changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fhanik. I left a couple of comments.

jzheaux
jzheaux requested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, @fhanik! I've provided some feedback inline.

@fhanik fhanik changed the title Enable AuthenticationProvider configuration in saml2Login Enable AuthenticationManager configuration in saml2Login Dec 10, 2019
jzheaux
jzheaux requested changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, sir. I've left some additional feedback inline.

@fhanik
Ensure that both matchers carry the same pattern.
612de49 
AbstractAuthenticationProcessingFilter.setRequiresAuthenticationRequestMatcher is public and final,
so there is a risk that the underlying matcher can become different if one is not careful.
@fhanik
Allow configuration of AuthenticationManagerResolver in saml2Login()
bbf200f 
Fixes spring-projectsgh-7654

spring-projects#7654
@fhanik fhanik force-pushed the feature/saml2_login_configurer_tests branch from bdefb66 to bbf200f Compare December 17, 2019 18:28
@fhanik fhanik merged commit af41594 into spring-projects:master Dec 17, 2019
@eleftherias eleftherias added this to the 5.3.0.M1 milestone Jan 8, 2020
@jzheaux jzheaux mentioned this pull request Feb 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja jgrandja requested changes

@jzheaux jzheaux jzheaux approved these changes

Assignees

@fhanik fhanik

Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.0.M1
Development

Successfully merging this pull request may close these issues.

Allow configuration of AuthenticationManager in saml2Login()
4 participants
@fhanik @jzheaux @jgrandja @eleftherias