propagate saml authentication exception #7375 #7477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
requested changes
Sep 27, 2019
...g/springframework/security/saml2/provider/service/authentication/TestSaml2CryptoSupport.java
Outdated
Show resolved
Hide resolved
… and spring-projects#7375 Fixes spring-projectsgh-7377 Fixes spring-projectsgh-7375 spring-projects#7377 spring-projects#7375 Clean up code - Authentication request factory should only throw Saml2Exception - OpenSamlImplementation should only throw Saml2Exception - Move the OpenSamlImplementation package private methods to the right section
fhanik
force-pushed
the
feature/propagate_saml_authentication_exception
branch
from
e283887 to
22da2b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerMock removed as a test dependency. Testing converted using real data.
Fixes gh-7375