Skip to content

Remove and replace deprecated APIs marked for removal in 2.0.x #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

therepanic
Copy link
Contributor

Due to gh-1187, we should remove deprecates that are marked for removal from version 1.2.0.

Closes: gh-1187

@@ -19,6 +19,7 @@ dependencies {
api 'org.springframework:spring-context'
api 'org.springframework:spring-messaging'
api 'org.springframework:spring-tx'
testImplementation libs.spring.boot.starter.pulsar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since PulsarContainerFactoryCustomizer is only available directly in the starter, we should do this.

To be honest, I don't think this is a very good solution either. As an alternative, I would suggest making the test an integration test and moving it to the samples. To be honest, I don't see any other solution. What do you think?

Due to spring-projectsgh-1187, we should remove deprecates that are marked for removal
from version 1.2.0.

Closes: spring-projectsgh-1187

Signed-off-by: Andrey Litvitski <[email protected]>
@therepanic
Copy link
Contributor Author

Strangely, not all PulsarListenerTxnTests tests fail, only throwsExceptionWhenTransactionsAreRequired and ignoresSettingWhenNoTxnManagerAvailable. Any ideas what this could be? We register PulsarAutoConfiguration, and it seems like it should work as expected.

@onobc
Copy link
Collaborator

onobc commented Aug 10, 2025

Strangely, not all PulsarListenerTxnTests tests fail, only throwsExceptionWhenTransactionsAreRequired and ignoresSettingWhenNoTxnManagerAvailable. Any ideas what this could be? We register PulsarAutoConfiguration, and it seems like it should work as expected.

I will take a look but the txn tests are flaky and I have been meaning to dig in and understand why. It has not been obvious so far. I would first try to re-run failed in the GH actions and see if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "forRemoval" deprecations in 2.0.x
2 participants