Skip to content

GH-4054: Fix missing Nullable in deserialize methods #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

GH-4054: Fix missing Nullable in deserialize methods #4055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...main/java/org/springframework/kafka/support/serializer/DelegatingByTopicDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

import org.apache.kafka.common.header.Headers;
import org.apache.kafka.common.serialization.Deserializer;
import org.jspecify.annotations.Nullable;

/**
* A {@link Deserializer} that delegates to other deserializers based on the topic name.
Expand Down Expand Up @@ -74,12 +75,12 @@ public Object deserialize(String topic, byte[] data) {
}

@Override
public Object deserialize(String topic, Headers headers, byte[] data) {
public @Nullable Object deserialize(String topic, Headers headers, byte[] data) {
return findDelegate(topic).deserialize(topic, headers, data);
}

@Override
public Object deserialize(String topic, Headers headers, ByteBuffer data) {
public @Nullable Object deserialize(String topic, Headers headers, ByteBuffer data) {
return findDelegate(topic).deserialize(topic, headers, data);
}

Expand Down
4 changes: 2 additions & 2 deletions ...ka/src/main/java/org/springframework/kafka/support/serializer/DelegatingDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,13 @@ public Object deserialize(String topic, byte[] data) {
}

@Override
public Object deserialize(String topic, Headers headers, byte[] data) {
public @Nullable Object deserialize(String topic, Headers headers, byte[] data) {
Deserializer<?> deserializer = getDeserializerByHeaders(headers);
return deserializer == null ? data : deserializer.deserialize(topic, headers, data);
}

@Override
public Object deserialize(String topic, Headers headers, ByteBuffer data) {
public @Nullable Object deserialize(String topic, Headers headers, ByteBuffer data) {
Deserializer<?> deserializer = getDeserializerByHeaders(headers);
return deserializer == null ? data : deserializer.deserialize(topic, headers, data);
}
Expand Down
6 changes: 3 additions & 3 deletions ...afka/src/main/java/org/springframework/kafka/support/serializer/RetryingDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ public void configure(Map<String, ?> configs, boolean isKey) {
}

@Override
public T deserialize(String topic, byte[] data) {
public @Nullable T deserialize(String topic, byte[] data) {
return this.retryOperations.execute(context -> this.delegate.deserialize(topic, data), this.recoveryCallback);
}

@Override
public T deserialize(String topic, Headers headers, byte[] data) {
public @Nullable T deserialize(String topic, Headers headers, byte[] data) {
return this.retryOperations.execute(context -> this.delegate.deserialize(topic, headers, data), this.recoveryCallback);
}

@Override
public T deserialize(String topic, Headers headers, ByteBuffer data) {
public @Nullable T deserialize(String topic, Headers headers, ByteBuffer data) {
return this.retryOperations.execute(context -> this.delegate.deserialize(topic, headers, data), this.recoveryCallback);
}

Expand Down