Skip to content

Rephrase replication factor documentation #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
+5 −5
Merged

Rephrase replication factor documentation #3909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b29ee53
Fix docs on `RetryableTopic.replicationFactor()`
sh-cho May 17, 2025
49c48d0
Rephrase replicationFactor description about broker version
sh-cho May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-kafka/src/main/java/org/springframework/kafka/annotation/RetryableTopic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
/**
* The replication factor for the automatically created topics. Expressions must
* resolve to a short or a String that can be parsed as such. Default is -1 to use the
* broker default if the broker is earlier than version 2.4, an explicit value is
* broker default. If the broker is earlier than version 2.4, an explicit value is
* required.
*
* @return the replication factor.
Expand Down
8 changes: 4 additions & 4 deletions ...ka/src/main/java/org/springframework/kafka/retrytopic/RetryTopicConfigurationBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,8 +432,8 @@ public RetryTopicConfigurationBuilder doNotAutoCreateRetryTopics() {
* Configure the topic creation behavior to auto create topics with the provided
* properties.
* @param numPartitions the number of partitions.
* @param replicationFactor the replication factor (-1 to use the broker default if the
* broker is version 2.4 or later).
* @param replicationFactor the replication factor (-1 to use the broker default. If the
* broker is earlier than version 2.4, an explicit value is required).
* @return the builder.
*/
public RetryTopicConfigurationBuilder autoCreateTopicsWith(@Nullable Integer numPartitions, @Nullable Short replicationFactor) {
Expand All @@ -447,8 +447,8 @@ public RetryTopicConfigurationBuilder autoCreateTopicsWith(@Nullable Integer num
* properties.
* @param shouldCreate true to auto create.
* @param numPartitions the number of partitions.
* @param replicationFactor the replication factor (-1 to use the broker default if the
* broker is version 2.4 or later).
* @param replicationFactor the replication factor (-1 to use the broker default. If the
* broker is earlier than version 2.4, an explicit value is required).
* @return the builder.
*/
public RetryTopicConfigurationBuilder autoCreateTopics(@Nullable Boolean shouldCreate, @Nullable Integer numPartitions,
Expand Down