Skip to content

Conversation

@cedric-schaller
Copy link
Contributor

GH-3176: Setting the Kafka Streams property default.dsl.store has no effect

This is a proposal to fix GH-3176 (#3176)

@cedric-schaller cedric-schaller force-pushed the bugfix/GH-3176_take-property-default.dsl.store-into-account branch 3 times, most recently from c588425 to 2a9393f Compare April 4, 2024 15:22
@sobychacko
Copy link
Contributor

@cedric-schaller There are merge conflicts in the PR currently since we merged another change that modified the StreamsBuilderFactoryBean. Could you rebase the PR against the latest main? Thanks!

@cedric-schaller cedric-schaller force-pushed the bugfix/GH-3176_take-property-default.dsl.store-into-account branch from 2a9393f to f0a0aaa Compare April 5, 2024 05:09
@cedric-schaller
Copy link
Contributor Author

@sobychacko I have now finalized the PR. Please let me know if you expect anything else from me.

@sobychacko
Copy link
Contributor

@cedric-schaller Thanks. I started a PR build; we can merge these changes once that is green.

@sobychacko sobychacko merged commit 5ca65cc into spring-projects:main Apr 5, 2024
@cedric-schaller
Copy link
Contributor Author

@sobychacko I would appreciate cherry-picking this fix to 3.0.x and 3.1.x as we use 3.1.x on our project and need this feature. Would you like me to create 2 PR for this, one for each branch?

@artembilan
Copy link
Member

@cedric-schaller , see the issue for this this PR and from there you can follow with connected issues.
And this one points that the fix has made it into a 3.1.x branch: #3181.

And we have releases today.

Hope that helps somehow.

@cedric-schaller
Copy link
Contributor Author

@artembilan I am sorry, I missed these commits. Thanks for answering, and I am looking forward to using the new release!

@sobychacko
Copy link
Contributor

@cedric-schaller We removed the property usage (StreamsConfig.DEFAULT_DSL_STORE_CONFIG) from the main branch test you added (3.2.0-SNAPSHOT) as this has caused some deprecation and other related compiler warnings in our builds. I verified the behavior using the strategies in KIP-954. Please take a look at the related commit. In the 3.1.x and 3.0.x branches, the property usage is intact in the test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting the Kafka Streams property default.dsl.store has no effect

3 participants