-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GH-3176: Take property default.dsl.store into account #3177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-3176: Take property default.dsl.store into account #3177
Conversation
spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java
Show resolved
Hide resolved
.../java/org/springframework/kafka/config/StreamsBuilderFactoryBeanInMemoryStateStoreTests.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/kafka/config/StreamsBuilderFactoryBeanInMemoryStateStoreTests.java
Show resolved
Hide resolved
.../java/org/springframework/kafka/config/StreamsBuilderFactoryBeanInMemoryStateStoreTests.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/kafka/config/StreamsBuilderFactoryBeanInMemoryStateStoreTests.java
Show resolved
Hide resolved
c588425 to
2a9393f
Compare
|
@cedric-schaller There are merge conflicts in the PR currently since we merged another change that modified the |
2a9393f to
f0a0aaa
Compare
|
@sobychacko I have now finalized the PR. Please let me know if you expect anything else from me. |
|
@cedric-schaller Thanks. I started a PR build; we can merge these changes once that is green. |
|
@sobychacko I would appreciate cherry-picking this fix to 3.0.x and 3.1.x as we use 3.1.x on our project and need this feature. Would you like me to create 2 PR for this, one for each branch? |
|
@cedric-schaller , see the issue for this this PR and from there you can follow with connected issues. And we have releases today. Hope that helps somehow. |
|
@artembilan I am sorry, I missed these commits. Thanks for answering, and I am looking forward to using the new release! |
|
@cedric-schaller We removed the property usage ( |
GH-3176: Setting the Kafka Streams property default.dsl.store has no effect
This is a proposal to fix GH-3176 (#3176)