Skip to content

Conversation

NathanQingyangXu
Copy link
Contributor

in ConsumerFactory interface, the following two methods seems counter-intuitive:

Consumer<K, V> createConsumer(@Nullable String groupId, @Nullable String clientIdPrefix,
			@Nullable String clientIdSuffix);
default Consumer<K, V> createConsumer(@Nullable String groupId, @Nullable String clientIdPrefix,
			@Nullable String clientIdSuffix, @Nullable Properties properties) {

		return createConsumer(groupId, clientIdPrefix, clientIdSuffix);
	}

seems we should switch the default relationship the other way.

Also fixed some grammatical and logging defects in other classes

@sobychacko sobychacko added this to the 3.1.1 milestone Dec 18, 2023
@sobychacko sobychacko merged commit e6faa06 into spring-projects:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants