Skip to content

GH-2927 Resolve subclasses of EmbeddedKafkaBroker in tests #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 15, 2023
Merged

GH-2927 Resolve subclasses of EmbeddedKafkaBroker in tests #2931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf0245d
GH-2927 Resolve subclasses of EmbeddedKafkaBroker in tests
Sh1ftry Dec 11, 2023
d3e0a45
GH-2927 Test that zk broker can be resolved
Sh1ftry Dec 15, 2023
6bc290e
Add `@author`
artembilan Dec 15, 2023
ef1bd4e
Add `@author`
artembilan Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...a-test/src/main/java/org/springframework/kafka/test/condition/EmbeddedKafkaCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
* @author Artem Bilan
* @author Pawel Lozinski
* @author Adrian Chlebosz
* @author Michał Padula
*
* @since 2.3
*
Expand All @@ -72,7 +73,7 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
return false;
}
else {
return parameterContext.getParameter().getType().equals(EmbeddedKafkaBroker.class);
return EmbeddedKafkaBroker.class.isAssignableFrom(parameterContext.getParameter().getType());
}
}

Expand Down
8 changes: 8 additions & 0 deletions ...t/src/test/java/org/springframework/kafka/test/condition/EmbeddedKafkaConditionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,14 @@
import org.junit.jupiter.api.Test;

import org.springframework.kafka.test.EmbeddedKafkaBroker;
import org.springframework.kafka.test.EmbeddedKafkaZKBroker;
import org.springframework.kafka.test.context.EmbeddedKafka;
import org.springframework.kafka.test.utils.KafkaTestUtils;

/**
* @author Gary Russell
* @author Michał Padula
*
* @since 2.3
*
*/
Expand All @@ -41,4 +44,9 @@ public void test(EmbeddedKafkaBroker broker) {
assertThat(broker.getPartitionsPerTopic()).isEqualTo(3);
}

@Test
public void testResolver(EmbeddedKafkaZKBroker broker) {
assertThat(broker).isNotNull();
}

}