GH-2239: Fix Boot AutoConfiguration #2343
Merged
+86
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See spring-projects#2239 The previous commit removed the implicit bootstrap in favor of enforcing the user to use the `@EnableKafkaRretryTopic` or explicitly extend `RetryTopicConfigurationSupport`. Unfortunately, this breaks Spring Boot because it can auto configure a `RetryTopicConfiguration` bean, which means the infrastructure beans are required. Fallback to late binding of the infrastructure beans if a `RetryTopicConfiguration` bean is found in the application context. Tested with a Boot app. **cherry-pick to main**
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2239
The previous commit removed the implicit bootstrap in favor of enforcing the
user to use the
@EnableKafkaRretryTopicor explicitly extendRetryTopicConfigurationSupport.Unfortunately, this breaks Spring Boot because it can auto configure a
RetryTopicConfigurationbean, which means the infrastructure beans are required.Fallback to late binding of the infrastructure beans if a
RetryTopicConfigurationbean is found in the application context.
Tested with a Boot app.
cherry-pick to main