Skip to content

GH-1501: Add Micrometer Support for KafkaStreams #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2020
Merged

GH-1501: Add Micrometer Support for KafkaStreams #1502

merged 2 commits into from
Jun 11, 2020

Conversation

garyrussell
Copy link
Contributor

Resolves #1501

@garyrussell garyrussell mentioned this pull request Jun 11, 2020
Closed
artembilan
artembilan requested changes Jun 11, 2020
View reviewed changes
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but one concern

@artembilan artembilan merged commit e788c70 into spring-projects:master Jun 11, 2020
@garyrussell garyrussell deleted the GH-1501 branch June 15, 2020 17:23
@snicoll
Copy link
Member

snicoll commented Jun 19, 2020 •
edited
Loading

@garyrussell this change is not consistent with what we have for producers and consumers. There was a addListener and getListeners(). I agree that the FactoryBean contract makes it a little bit different but the listener being handled in the FactoryBean directly, I think it makes sense to adapt.

Thoughts?

@garyrussell
Copy link
Contributor Author

Good point; will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artembilan artembilan artembilan requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Micrometer for KafkaStreams

3 participants

@garyrussell @snicoll @artembilan