Skip to content

Fix LogMessage formatting placeholders in MqttHeaderMapper.java #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix LogMessage formatting placeholders in MqttHeaderMapper.java #8888

merged 2 commits into from
Feb 7, 2024

Conversation

wilx
Copy link
Contributor

@wilx wilx commented Feb 7, 2024

The placeholders are wrong and result in log messages like this:

o.s.i.mqtt.support.MqttHeaderMapper      : headerName=[{0}] WILL be mapped, matched pattern={1}

@artembilan artembilan added this to the 6.3.0-M1 milestone Feb 7, 2024
@artembilan artembilan merged commit 8b877fc into spring-projects:main Feb 7, 2024
@wilx wilx deleted the patch-1 branch February 7, 2024 15:24
artembilan pushed a commit that referenced this pull request Feb 7, 2024
@wilx @artembilan
Fix LogMessage placeholders in MqttHeaderMapper
623d136 
Fixes: #8888

* Fix `LogMessage` formatting placeholders in `MqttHeaderMapper`

**cherry-pick to `6.2.x` & `6.1.x`

(cherry picked from commit 8b877fc)
@spring-builds spring-builds mentioned this pull request Feb 7, 2024
Closed
artembilan pushed a commit that referenced this pull request Feb 7, 2024
@wilx @artembilan
Fix LogMessage placeholders in MqttHeaderMapper
5ea36e4 
Fixes: #8888

* Fix `LogMessage` formatting placeholders in `MqttHeaderMapper`

**cherry-pick to `6.2.x` & `6.1.x`

(cherry picked from commit 8b877fc)
@spring-builds spring-builds mentioned this pull request Feb 7, 2024
Closed
@artembilan
Copy link
Member

... and cherry-picked to 6.2.x & 6.1.x

@wilx ,
thank you for contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
(EOL) for: backport-to-6.1.x (EOL) for: backport-to-6.2.x in: mqtt status: backported type: bug
Projects
None yet
Milestone
6.3.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@wilx @artembilan @spring-builds