Remove unused ThreadLocal from RedisStoreMSource #8663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RedisStoreMessageSource` relies on an `IntegrationResourceHolder` for a while already. Its internal `ThreadLocal` is just out of use. * Remove that `resourceHolder` property and related methods to interact with it. * Mention the `IntegrationResourceHolder` and `store` attribute in the `redis.adoc`
garyrussell
suggested changes
Jun 28, 2023
...dis/src/main/java/org/springframework/integration/redis/inbound/RedisStoreMessageSource.java
Show resolved
Hide resolved
Co-authored-by: Gary Russell <[email protected]>
garyrussell
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RedisStoreMessageSourcerelies on anIntegrationResourceHolderfor a while already.Its internal
ThreadLocalis just out of use.resourceHolderproperty and related methods to interact with it.IntegrationResourceHolderandstoreattribute in theredis.adoc