Fix MQTT Inbound readyToSubscribeOnStart logic
#8557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot always reset `readyToSubscribeOnStart` to `false` in the `stop()` since we may be connected to `ClientManager` and have `cleanStart` option, so we `unsubscribe()` in the stop and then when we start there is no way to subscribe back * Reset `readyToSubscribeOnStart` in the `AbstractMqttMessageDrivenChannelAdapter.doStop()` only if we don't unsubscribe for a `cleanSession` reason. * Also reset it in the `connectionLost`, so next `connectComplete` will take care about subscription or `readyToSubscribeOnStart` state change * Use `isActive()` instead of `isRunning()` in the `connectComplete()` since there is a race condition when connection is established but `doStart()` has not returned yet, but already passed `if (this.readyToSubscribeOnStart)` line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot always reset
readyToSubscribeOnStarttofalsein thestop()since we may be connected toClientManagerand havecleanStartoption, so weunsubscribe()in the stop and then when we start there is no way to subscribe backreadyToSubscribeOnStartin theAbstractMqttMessageDrivenChannelAdapter.doStop()only if we don't unsubscribe for acleanSessionreason.connectionLost, so nextconnectCompletewill take care about subscription orreadyToSubscribeOnStartstate changeisActive()instead ofisRunning()in theconnectComplete()since there is a race condition when connection is established butdoStart()has not returned yet, but already passedif (this.readyToSubscribeOnStart)line