GH-4013: TCP DSL Improvements #4015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#4013 Add Net/NIO specific Server/Client connection factory specs.
artembilan
requested changes
Feb 8, 2023
| TcpNioClientConnectionFactory client = Tcp.nioClient("localhost", 0) | ||
| .tcpSocketSupport(sockSupp) | ||
| .usingDirectBuffers(true) | ||
| .tcpNioConnectionSupport(conSupp) |
There was a problem hiding this comment.
Cannot we call methods as simple as socketSupport, connectionSupport and socketFactorySupport?
We are really in the context of Tcp.netClient builder or Tcp.nioClient, so it sounds redundant for me to mention tcp or nio in every method of the builder again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4013
Add Net/NIO specific Server/Client connection factory specs.