Do not build exception instances in advance #3983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Jan 5, 2023
Comment on lines
284
to
286
| throw new MessagingException(getClass().getSimpleName() + | ||
| " was out of capacity (" + this.groupCapacity + ") for group '" + groupId + | ||
| "', try constructing it with a larger number."); |
There was a problem hiding this comment.
This should be extracted to a method to avoid the duplicate code.
When no `cause` and no clean context of the exception thrown, the code place where an exception has been created is confusing. * Fix `SimpleMessageStore` to create an `out of capacity` exception in the `addMessagesToGroup()` exactly at the point where it is thrown * Fix `FunctionExpression` and `SupplierExpression` do not pre-create `readOnlyException`: it is unlikely these kind of expressions are going to be used in the SpEL `write` context, so we save some time and memory not creating extra object and the plain call `throw new` gives us a clean context what method call has ended up with such an exception
…eStore` to avoid duplication. Even if we got in the end extra line in th stack trace, it is still clear from where it is thrown: ``` org.springframework.messaging.MessagingException: SimpleMessageStore was out of capacity (1) for group 'foo', try constructing it with a larger number. at org.springframework.integration.store.SimpleMessageStore.outOfCapacityException(SimpleMessageStore.java:324) at org.springframework.integration.store.SimpleMessageStore.addMessagesToGroup(SimpleMessageStore.java:302) at org.springframework.integration.store.AbstractMessageGroupStore.addMessageToGroup(AbstractMessageGroupStore.java:189) at org.springframework.integration.store.SimpleMessageStoreTests.shouldNotHoldMoreThanGroupCapacity(SimpleMessageStoreTests.java:128) ```
artembilan
force-pushed
the
dont_do_pre-build_exceptions
branch
from
0a78eaf to
a7616f0
Compare
garyrussell
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no
causeand no clean context of the exception thrown, the code place where an exception has been created is confusing.SimpleMessageStoreto create anout of capacityexception in theaddMessagesToGroup()exactly at the point where it is thrownFunctionExpressionandSupplierExpressiondo not pre-createreadOnlyException: it is unlikely these kind of expressions are going to be used in the SpELwritecontext, so we save some time and memory not creating extra object and the plain callthrow newgives us a clean context what method call has ended up with such an exception