GH-3969: SFTP: Bring back support for empty path #3970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3969 In previous version for SFTP client (Jsch), the empty path for `LS` command has meant a `user home`. Turns out the MINA `SftpClient` does not support automatic user home resolution from the empty path. * Fix `SftpSession` to resolve an empty path into a user home via `canicalPath()` operation
garyrussell
reviewed
Dec 12, 2022
| remoteDir = remotePath; | ||
| } | ||
| } | ||
| remoteDir = remoteDir.length() == 0 ? this.sftpClient.canonicalPath("") : remoteDir; |
There was a problem hiding this comment.
Although this works, I wonder if the intent would be clearer with this...
Suggested change
| remoteDir = remoteDir.length() == 0 ? this.sftpClient.canonicalPath("") : remoteDir; | |
| remoteDir = remoteDir.length() == 0 ? this.sftpClient.canonicalPath(".") : remoteDir; |
There was a problem hiding this comment.
I don't know, Gary: even if my tests against MINA confirms that . is resolved to the user home, it was a reason before with Jsch to have it as an empty string.
BTW, the Jsch client does this: byte[] _home=_realpath("");. So, it is really an empty string for user home request. 🤷
See their ChannelSftp.getHome()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3969
In previous version for SFTP client (Jsch), the empty path for
LScommand has meant auser home.Turns out the MINA
SftpClientdoes not support automatic user home resolution from the empty path.SftpSessionto resolve an empty path into a user home viacanicalPath()operation