Skip to content

Conversation

artembilan
Copy link
Member

The Observation populates slightly different Micrometer timer names and their tags

  • Fix MicrometerNodeEnhancer to search timers in the registry according to the Observation convention if the provided component is observed
  • For that purpose expose an IntegrationManagement.isObserved() option to check of component is instrumented with an Observation
  • Improve the logic in the IntegrationGraphServer to delegate into a Function to call micrometerEnhancer.enhance() instead of static property which might not be OK in the environment where several integration applications are ran in the same JVM

The `Observation` populates slightly different Micrometer timer names and their tags

* Fix `MicrometerNodeEnhancer` to search timers in the registry according to the `Observation`
convention if the provided component is observed
* For that purpose expose an `IntegrationManagement.isObserved()` option to check
of component is instrumented with an `Observation`
* Improve the logic in the `IntegrationGraphServer` to delegate into a `Function`
to call `micrometerEnhancer.enhance()` instead of `static` property which might not
be OK in the environment where several integration applications are ran in the same JVM
* Add `@Nullable` to `MicrometerNodeEnhancer.buildTimerStats()` param to satisfy this method contract

Co-authored-by: Gary Russell <[email protected]>
@garyrussell garyrussell merged commit 49a9b7e into spring-projects:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants