Obtain observed timers in the Integration Graph #3967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Observation` populates slightly different Micrometer timer names and their tags * Fix `MicrometerNodeEnhancer` to search timers in the registry according to the `Observation` convention if the provided component is observed * For that purpose expose an `IntegrationManagement.isObserved()` option to check of component is instrumented with an `Observation` * Improve the logic in the `IntegrationGraphServer` to delegate into a `Function` to call `micrometerEnhancer.enhance()` instead of `static` property which might not be OK in the environment where several integration applications are ran in the same JVM
garyrussell
suggested changes
Dec 16, 2022
...gration-core/src/main/java/org/springframework/integration/graph/MicrometerNodeEnhancer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/integration/support/management/IntegrationManagement.java
Outdated
Show resolved
Hide resolved
* Add `@Nullable` to `MicrometerNodeEnhancer.buildTimerStats()` param to satisfy this method contract Co-authored-by: Gary Russell <[email protected]>
garyrussell
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Observationpopulates slightly different Micrometer timer names and their tagsMicrometerNodeEnhancerto search timers in the registry according to theObservationconvention if the provided component is observedIntegrationManagement.isObserved()option to check of component is instrumented with anObservationIntegrationGraphServerto delegate into aFunctionto callmicrometerEnhancer.enhance()instead ofstaticproperty which might not be OK in the environment where several integration applications are ran in the same JVM