Fix double start for AbstractEndpoint
#3928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we use POJO methods in the `IntegrationFlowAdapter`, the `IntegrationFlowAdapter` is set as a `target` for the `MessagingMethodInvokerHelper`. When endpoint is started by the application context, such a `start()` is propagated down to the `MessagingMethodInvokerHelper`. And in our case back into an `IntegrationFlowAdapter` instance. This one, in turn, starts its `IntegrationFlow` internally which leads to the start of the mentioned endpoint in the beginning. Therefore, we cause a recursive `start()` call on this endpoint from itself. The `running` flag is set when we are already done with the `doStart()` logic. Therefore a recursive `start()` call leads to two concurrent polling tasks in the `AbstractPollingEndpoint`. * Check also for the `active` flag in the `AbstractEndpoint.start()` and reset it in case of exception in the `doStart()` **Cherry-pick to `5.5.x`**
|
this was the easiest way to fix the problem. Thank you! |
…on`: the `doStart()` cannot throw unchecked exceptions by definition
garyrussell
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Fix double start for `AbstractEndpoint` When we use POJO methods in the `IntegrationFlowAdapter`, the `IntegrationFlowAdapter` is set as a `target` for the `MessagingMethodInvokerHelper`. When endpoint is started by the application context, such a `start()` is propagated down to the `MessagingMethodInvokerHelper`. And in our case back into an `IntegrationFlowAdapter` instance. This one, in turn, starts its `IntegrationFlow` internally which leads to the start of the mentioned endpoint in the beginning. Therefore, we cause a recursive `start()` call on this endpoint from itself. The `running` flag is set when we are already done with the `doStart()` logic. Therefore a recursive `start()` call leads to two concurrent polling tasks in the `AbstractPollingEndpoint`. * Check also for the `active` flag in the `AbstractEndpoint.start()` and reset it in case of exception in the `doStart()` **Cherry-pick to `5.5.x`** * * Change assert for message timestamps to `isCloseTo()` with percentage * * Change `catch` in the `AbstractEndpoint.start()` to `RuntimeException`: the `doStart()` cannot throw unchecked exceptions by definition * * Fix imports in `AbstractEndpoint`
|
...and cherry-picked as 8f809a7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use POJO methods in the
IntegrationFlowAdapter, theIntegrationFlowAdapteris set as atargetfor theMessagingMethodInvokerHelper. When endpoint is started by the application context, such astart()is propagated down to theMessagingMethodInvokerHelper.And in our case back into an
IntegrationFlowAdapterinstance. This one, in turn, starts itsIntegrationFlowinternally which leads to the start of the mentioned endpoint in the beginning.Therefore, we cause a recursive
start()call on this endpoint from itself. Therunningflag is set when we are already done with thedoStart()logic. Therefore a recursivestart()call leads to two concurrent polling tasks in theAbstractPollingEndpoint.activeflag in theAbstractEndpoint.start()and reset it in case of exception in thedoStart()Cherry-pick to
5.5.x