GH-3679: Better caching for SpringIntegrationTest #3792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3679 The `@SpringIntegrationTest` makes a test cache key based on its attributes values when the same application context can be used in different test classes with different endpoints to have stopped originally. * Rework an `IntegrationEndpointsInitializer` to the `SpringIntegrationTestExecutionListener` which consult a `MockIntegrationContext` for endpoints to be started or not before the test execution and definitely stopped after the test execution to have a flexibility with the cached context * Improve a `MockIntegrationContext` to gather `AbstractEndpoint` beans and have them marked for stopping in the beginning of the application context. The `SpringIntegrationTestExecutionListener` takes care about startup in its `beforeTestClass()` * Verify different state for the `SpringIntegrationTest` with the `CachedSpringIntegrationTestAnnotationTests`
when no `@SpringIntegrationTest.noAutoStartup()` is configured * Fix `CachedSpringIntegrationTestAnnotationTests` check `isRunning()` for the endpoint under the testing instead of `isAutoStartup()` which is changed in one test class, but not other, and the order of their execution would matter * Migrate `MockMessageSourceTests` to JUnit 5 as a roadmap of the whole project
|
BTW, with the |
garyrussell
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3679
The
@SpringIntegrationTestmakes a test cache key based on its attributes valueswhen the same application context can be used in different test classes
with different endpoints to have stopped originally.
IntegrationEndpointsInitializerto theSpringIntegrationTestExecutionListenerwhich consult a
MockIntegrationContextfor endpoints to be started or not beforethe test execution and definitely stopped after the test execution to have a flexibility
with the cached context
MockIntegrationContextto gatherAbstractEndpointbeans and have themmarked for stopping in the beginning of the application context.
The
SpringIntegrationTestExecutionListenertakes care about startup in itsbeforeTestClass()SpringIntegrationTestwith theCachedSpringIntegrationTestAnnotationTests