GH-3688: Fix WS DSL for proper values propagation #3689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3688 The `WebServiceTemplate` is populated with some defaults from its ctor. We should rely on the target default template values as much as possible and don't override them to `null` if end-user doesn't ask about that explicitly * Fix `BaseWsOutboundGatewaySpec` extensions to populate values to the target gateway only if they are not null - therefore provided by end-user * If end-user wants them explicitly `null`, it is better to do that via externally configured template. See overloaded variants for DSL: `Ws.marshallingOutboundGateway(WebServiceTemplate)` and `Ws.simpleOutboundGateway(WebServiceTemplate)` **Cherry-pick to `5.4.x` & `5.3.x`**
garyrussell
approved these changes
Dec 13, 2021
|
... and cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3688
The
WebServiceTemplateis populated with some defaults from its ctor.We should rely on the target default template values as much as possible
and don't override them to
nullif end-user doesn't ask about that explicitlyBaseWsOutboundGatewaySpecextensions to populate values to the target gatewayonly if they are not null - therefore provided by end-user
null, it is better to do that viaexternally configured template.
See overloaded variants for DSL:
Ws.marshallingOutboundGateway(WebServiceTemplate)and
Ws.simpleOutboundGateway(WebServiceTemplate)Cherry-pick to
5.4.x&5.3.x