Remove Disposables abstraction
#3681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `Disposables` since it is a package protected therefore could not be used outside * Remove the logic relevant ot the `Disposables` in the `MessagingAnnotationPostProcessor` logic * Replace a `registerSingleton()` and `initializeBean()` with the proper `registerBeanDefinition()` and `getBean()` usage. This way bean are going to be destroyed properly * Remove `MessagingAnnotationPostProcessorChannelCreationTests` since its mocking logic is too vague and really covered with many other real tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disposablessince it is a package protected therefore could not be used outsideDisposablesin theMessagingAnnotationPostProcessorlogicregisterSingleton()andinitializeBean()with the properregisterBeanDefinition()and
getBean()usage.This way bean are going to be destroyed properly
MessagingAnnotationPostProcessorChannelCreationTestssince its mocking logic is too vagueand really covered with many other real tests.