GH-3627: Fix race condition NPE in MqttPahoMDCA #3628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3627 The `destroy()`, and therefore `stop()` could be called from the `MqttConnectionFailedEvent` handling in the same thread resetting the `client` property to `null`. * Check for `this.client != null` in the next block of the `connectAndSubscribe()` to avoid NPE * Check for `isActive()` in the `scheduleReconnect()` to be sure do not reconnect if channel adapter has been stopped already **Cherry-pick to `5.4.x`**
garyrussell
approved these changes
Sep 9, 2021
|
... and cherry-picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3627
The
destroy(), and thereforestop()could be called from theMqttConnectionFailedEventhandlingin the same thread resetting the
clientproperty tonull.this.client != nullin the next block of theconnectAndSubscribe()to avoid NPEisActive()in thescheduleReconnect()to be sure do not reconnect if channel adapterhas been stopped already
Cherry-pick to
5.4.x