Fix to address expectation of proper exception #3611
Conversation
This fix changes the WebFluxRequestExecutingMessageHandler The change specifically changes the contruction of the WebClientResponseException to use the `create` factory method. This change addresses issue spring-projects#3610.
|
@djgraff209 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@djgraff209 Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Please, fix it as we discussed on Gitter: https://gitter.im/spring-projects/spring-integration?at=611069649484630efa2a4c46.
Also consider to cover it somehow with the test.
See #3612 for the place where you could inject the logic for your change.
Thank you!
|
Will attempt to provide unit test to cover later today. |
Updated code to use simplified exception construction that is more tolerant of larger payloads. Updated unit tests to check for specific exception types.
Corrected checkstyle error in imports. Corrected whitespace between casts. Corrected trailing whitespace.
|
Hm. The general rule if I request changes, you have to do them. Otherwise that means everything is up to me and you are good. So, thank you for your patience with that nasty byte buffer issue and contribution. |
|
Absolutely not a problem. I have been in the corporate world for many years and rigor like I'm trying to follow is meant mainly to reduce the burden on the owners. Thanks again! |
|
... and cherry-picked to |
3 participants
This fix changes the WebFluxRequestExecutingMessageHandler
The change specifically changes the contruction of the
WebClientResponseException to use the
createfactory method.Fixes #3610.