Skip to content

Conversation

@trgpa
Copy link
Contributor

@trgpa trgpa commented Jul 13, 2021

Fixes #3424

  • Logging statements that test cases depend on are kept unchanged (or should I have revised the test cases too?)
  • Some include non-final variables so we cannot use LogAcessor.debug(Supplier<? extends CharSequence>). It might be a good idea to have methods similar to LogMessage.format().

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!
This is really great change.

We really can merge this as is, but still would like to share my thoughts on the matter in the review.

Also: let us know if that doesn't bother you to add your official name to all the affected classes.

@trgpa trgpa requested a review from artembilan July 14, 2021 11:22
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I reviewed this a couple days ago, but looks like I didn't press "Submit review". 🤦

@trgpa trgpa requested a review from artembilan July 17, 2021 12:29
@artembilan artembilan merged commit 9c718c3 into spring-projects:main Jul 19, 2021
@artembilan
Copy link
Member

@trungPa ,

thank you very much for the contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More refactoring to use a LogAccessor from the IntegrationObjectSupport

2 participants