GH-3578: Fix JdbcMessageStore.getMessageGroup() #3579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3578 The `JdbcTemplate.queryForMap()` extract values for columns to the closer target driver types. For example H2 and Derby return `Long` for `BIGINT`. Oracle for its `NUMBER(19,0)` returns `BigInteger`. This makes the code in the `JdbcMessageStore.getMessageGroup()` not platform independent. * Fix `JdbcMessageStore` to map `ResultSet` to the `MessageGroupMetadata` directly. Mostly reinstating the previous behavior * For that reason expose a default ctor for `MessageGroupMetadata` and extract some setters to make code in the `JdbcMessageStore` more cleaner. * This opens for us a possibility to implement a `MessageGroupStore.getGroupMetadata(groupId)` for `JdbcMessageStore` * Fix deprecation for `Flux.limitRequest()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3578
The
JdbcTemplate.queryForMap()extract values for columns to the closer target driver types.For example H2 and Derby return
LongforBIGINT.Oracle for its
NUMBER(19,0)returnsBigInteger.This makes the code in the
JdbcMessageStore.getMessageGroup()not platform independent.
JdbcMessageStoreto mapResultSetto theMessageGroupMetadatadirectly.
Mostly reinstating the previous behavior
MessageGroupMetadataand extract some setters to make code in the
JdbcMessageStoremore cleaner.MessageGroupStore.getGroupMetadata(groupId)for
JdbcMessageStoreFlux.limitRequest()