GH-3326: TCP: Support Unsolicited Server Messages #3327
Conversation
Resolves spring-projects#3326 - OB Gateway - send unsolicited messages and late replies to a channel - Support multiple `TcpSender`s
artembilan
left a comment
artembilan
left a comment
There was a problem hiding this comment.
I thought first of all that this has to be supported via an ApplicationEvent support, but technically it doesn't matter that we are going to send them into some configured channel. This is similar to discardChannel in other places, but just with a different name and of course different purpose.
So, give me an answer to those my two minor concerns and we are good to go with merge!
Thank you!
| return this; | ||
| } | ||
|
|
||
| public TcpOutboundGatewaySpec unsolictedMessageChannelName(String channelName) { |
There was a problem hiding this comment.
Looks like you have there this setter as well setUnsolicitedMessageChannel(MessageChannel unsolicitedMessageChannel). Don't we need to have similar option here on DSL level?
Thanks
| * @param replyChannel The reply channel. | ||
| */ | ||
| public void setReplyChannel(MessageChannel replyChannel) { | ||
| this.setOutputChannel(replyChannel); |
There was a problem hiding this comment.
this. on method calls?
I guess you have just moved those existing setter over here for better class structure.
Nevertheless can we fix this. as well since we are already here in a change?
2 participants
Resolves #3326
TcpSenders