Skip to content

Conversation

jonatan-ivanov
Copy link
Member

TL;DR: this is a polishing PR as long as micrometer-metrics/micrometer#6700 is not merged (1.16.0). If that will happen, things can break without this change.

Details:
The Micrometer team is considering some improvements in the Observation API which involves changing the behavior of Observation.NOOP: micrometer-metrics/micrometer#6700
Observation.NOOP is not truly no-op right now, it does context propagation, we are trying to make it truly no-op in the PR above. The non-truly no-op version will still be used in certain scenarios (see NoopButScopeHandlingObservation). observation.isNoop() should be used for checking if an Observation is no-op or not instead of Observation.NOOP.

@jonatan-ivanov
Copy link
Member Author

Not sure what is going on, the build is failing with this (locally too):

Execution failed for task ':spring-integration-kafka:compileTestJava'.
> Compilation failed; see the compiler output below.
  /home/runner/work/spring-integration/spring-integration/spring-integration-kafka/src/test/java/org/springframework/integration/kafka/inbound/MessageSourceTests.java:338: error: reference to close is ambiguous
  		inOrder.verify(consumer).close(any());
  		                        ^
    both method close(Duration) in Consumer and method close(CloseOptions) in Consumer match

which seems unrelated to the change but main seems ok.

@artembilan artembilan added this to the 7.0.0-M3 milestone Sep 6, 2025
@artembilan artembilan merged commit 344ea9b into spring-projects:main Sep 6, 2025
2 of 3 checks passed
@jonatan-ivanov jonatan-ivanov deleted the is-noop branch September 8, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants