GH-10083: Apply Nullability to core util package
#10318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#10083 * Add null checks and `@Nullable` where appropriate * Handle optional `ErrorHandler` in `PartitionedDispatcher` * Use `Objects.requireNonNull()` for reflection method lookups * Add `Assert.notNull()` for UUID conversion Signed-off-by: Jooyoung Pyoung <[email protected]>
artembilan
requested changes
Aug 15, 2025
spring-integration-core/src/main/java/org/springframework/integration/util/ClassUtils.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/integration/aggregator/AbstractCorrelatingMessageHandler.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/integration/jdbc/channel/PostgresChannelMessageTableSubscriber.java
Outdated
Show resolved
Hide resolved
...tegration-jdbc/src/main/java/org/springframework/integration/jdbc/lock/JdbcLockRegistry.java
Outdated
Show resolved
Hide resolved
...n-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcChannelMessageStore.java
Outdated
Show resolved
Hide resolved
...egration-jdbc/src/main/java/org/springframework/integration/jdbc/store/JdbcMessageStore.java
Outdated
Show resolved
Hide resolved
* Add `@Contract` to `UUIDConverter` methods * Replace `Objects.requireNonNull` with ternary operator in `ClassUtils` Signed-off-by: Jooyoung Pyoung <[email protected]>
artembilan
requested changes
Aug 15, 2025
spring-integration-core/src/main/java/org/springframework/integration/util/UUIDConverter.java
Show resolved
Hide resolved
.../main/java/org/springframework/integration/aggregator/AbstractCorrelatingMessageHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/integration/aggregator/AbstractCorrelatingMessageHandler.java
Outdated
Show resolved
Hide resolved
* Add `@Contract` to `MessagingAnnotationUtils.findMessagePartAnnotation()`, `UUIDConverter.serialize()` * Remove redundant null checks after `UUIDConverter.getUUID()` Signed-off-by: Jooyoung Pyoung <[email protected]>
|
Merged as: 1bf5810. Nothing critical I have polished in the final commit. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083