GH-10314: Revise TcpListener.onMessage() contract for void
#10315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r `void` Fixes: spring-projects#10314 Looks like a `boolean` return for the `TcpListener.onMessage()` is a leftover of some earlier design or some idea which didn't make it into the project. On the other hand, all the logic in the project around this `onMessage()` usage is properly handled by the delegation or exceptions. * Change `TcpListener.onMessage()` to have a `void` as return type * Fix all the respective usages and simplify some implementations with removing those bogus `return false;` and using proper `if..else` logic if necessary * Fix some code style in the affected classes, like proper `assertThat` or diamond operators
cppwfs
requested changes
Aug 15, 2025
| */ | ||
| @Nullable Message<?> getReply() { | ||
| @Nullable | ||
| Message<?> getReply() { |
There was a problem hiding this comment.
Why is the @Nullable move to the line above the method?
There was a problem hiding this comment.
Because this method does not have modifiers and annotation is treated by formatter as for the whole method.
I agree on consistency discrepancy here, but I prefer to keep formatter happy to avoid unnecessary changes in the future .
| this.interceptedSenders.forEach(snder -> snder.removeDeadConnection(connection)); | ||
| if (sender != null && this.interceptedSenders != null | ||
| && !(sender instanceof TcpConnectionInterceptorSupport)) { | ||
|
|
There was a problem hiding this comment.
Blank line can probably be removed.
There was a problem hiding this comment.
Well, my preference for better readability is to have a blank line after multi-line if.
Same reason as with a blank line before method body after multi-line header.
cppwfs
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10314
Looks like a
booleanreturn for theTcpListener.onMessage()is a leftover of some earlier design or some idea which didn't make it into the project. On the other hand, all the logic in the project around thisonMessage()usage is properly handled by the delegation or exceptions.TcpListener.onMessage()to have avoidas return typereturn false;and using properif..elselogic if necessaryassertThator diamond operators