GH-10083: Apply Nullability to FTP module #10308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
requested changes
Aug 14, 2025
| .getValue(); | ||
| templateDefinition.getPropertyValues() // NOSONAR never null | ||
|
|
||
| Objects.requireNonNull(templateDefinition).getPropertyValues() |
There was a problem hiding this comment.
Would it be correct to say that we don't expect the templateDefinition returned from the builder should never be null?
There was a problem hiding this comment.
What you say is correct , but contract enforces us.
I wouldn’t spend too much time on XML parsers: I anticipate their deprecation and removal at some point.
Plus , this is not a critical execution path, so it is OK to say nothing and just follow the contract.
cppwfs
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083