Skip to content

Make pathFor protected to allow overriding #10289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

Make pathFor protected to allow overriding #10289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ration-jdbc/src/main/java/org/springframework/integration/jdbc/lock/JdbcLockRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public DistributedLock obtain(Object lockKey) {
}
}

private String pathFor(String input) {
protected String pathFor(String input) {
return UUIDConverter.getUUID(input).toString();
}

Expand Down
20 changes: 20 additions & 0 deletions ...n-jdbc/src/test/java/org/springframework/integration/jdbc/lock/JdbcLockRegistryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,26 @@ void testUnlockAfterLockStatusHasBeenExpiredAndDeleted() throws Exception {
.isThrownBy(lock::unlock);
}

@Test
void testPathForCanBeOverridden() {
DefaultLockRepository client = new DefaultLockRepository(dataSource);
client.setApplicationContext(this.context);
client.afterPropertiesSet();
client.afterSingletonsInstantiated();
JdbcLockRegistry registry = new JdbcLockRegistry(client) {
@Override
protected String pathFor(String input) {
return input;
}
};

final String lockKey = "foo";
Lock lock = registry.obtain(lockKey);
String lockPath = TestUtils.getPropertyValue(lock, "path", String.class);

assertThat(lockPath).isEqualTo(lockKey);
}

@SuppressWarnings("unchecked")
private static Map<String, Lock> getRegistryLocks(JdbcLockRegistry registry) {
return TestUtils.getPropertyValue(registry, "locks", Map.class);
Expand Down