GH-10083: Apply Nullability to core dispatcher package #10272
Merged
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartititonDispatcher.partition will always return at least 1 partition. So return value is wrapped with Objects.requireNonNull, for nullaway Related to: spring-projects#10083
artembilan
requested changes
Jul 28, 2025
...ion-core/src/main/java/org/springframework/integration/dispatcher/PartitionedDispatcher.java
Outdated
Show resolved
Hide resolved
… the `NullAway` error, than take the performance hit of using `requiresNonNull`
artembilan
requested changes
Jul 28, 2025
| } | ||
|
|
||
| @Override | ||
| @SuppressWarnings("NullAway") |
There was a problem hiding this comment.
Can we state in the comment to this annotation the reason?
Something similar to what I suggested in the review, but might be more specific to this situation.
…essWarning` is needed.
artembilan
requested changes
Jul 28, 2025
|
|
||
| @Override | ||
| @SuppressWarnings("NullAway") | ||
| @SuppressWarnings("NullAway") // Dataflow analysis limitation! |
There was a problem hiding this comment.
Yeah... That's not what I meant, especially not with a ! 😉
How about this?
Suggested change
| @SuppressWarnings("NullAway") // Dataflow analysis limitation! | |
| @SuppressWarnings("NullAway") // The partitions map never returns null according to partition hash |
There was a problem hiding this comment.
Thank you for the clarification. I thought that message was a bit terse. will update.
…nsMap is never null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartititonDispatcher.partition will always return at least 1 partition. So return value is wrapped with Objects.requireNonNull, for nullaway
Related to: #10083