Groovy Control Bus should skip non-singleton managed beans during script variables initialization [INT-2164]

[spring-operator]

Artem Bilan opened INT-2164 and commented

When in the application context exist some beans with scope +request+ or +session+ GroovyControlBusFactoryBean thorws Exception on

 
Object bean = this.beanFactory.getBean(name);

if command-message received from some queue channel, because RequestContext doesn't exist.
Especially: I think there is no any reason to use beans from custom scopes as ManagedResource.
So, it is solution:

 
for (String name : this.beanFactory.getBeanDefinitionNames()) {
  BeanDefinition def = ctxt.getBeanFactory().getBeanDefinition(name);  
  if (!def.isSingleton() || def.isAbstract()) continue;

---

Affects: 2.1 M3

Issue Links:

• Improve Groovy Control Bus to avoid overhead during script variables initialization with managed beans [INT-2567] #6546 Improve Groovy Control Bus to avoid overhead during script variables initialization with managed beans

[spring-operator]

Artem Bilan commented

How about assign it to me?

[spring-operator]

Artem Bilan commented

I have researched the ControlBus logic and I concluded: because some MesasgeChannels can be used as +managed resources+, and they, in turn, can be defined in +custom scope+, to skip all non-sigleton beans in GroovyControlBusFactoryBean.ManagedBeansScriptVariableGenerator.generateScriptVariables may break the application logic.
So, I suggest two solutions:

1. To skip all abstract & prototype beans and also to "choke" BeanCreationException on

Object bean = this.beanFactory.getBean(name);

for beans from custom scopes.
But I don't like this solution: script-variables from beanFactory +are builded for each message+ and having all managed resources in one command message is redundant.
2. Second solution is more more intellectually and and less resource capacious.
To introduce some internal MenagedResourcesBeanFactory as implementation of Map with orginal benFactory as delegator inside method get. And to include logic here about checking that bean is managed resource.
And in the end introduce only one script-variable - "beanFactory" as instance of this fake BeanFactory.
And now if we want to use some managed beans in our command-scripts we must do one simple change - prepend "old" script-variables with new one: "beanFactory".
The sample:

beanFactory.someChannel.stop()

Thoughts?

[spring-operator]

Oleg Zhurakousky commented

Since this is a bug I am moving it back to RC1 as well ;)

[spring-operator]

Mark Fisher commented

I've just issued a Pull Request that handles this problem in a minimal way, by catching the BeanCreationException within a loop and simply skipping those beans and continuing: #206

Once that PR is reviewed approvingly, I will merge it into master, and I will push this issue to 2.2 so that a more robust solution can be included if it's still deemed necessary.

[spring-operator]

Gary Russell commented

I concur - see comment in PR.

[spring-operator]

Artem Bilan commented

PR: #432

[spring-operator]

Oleg Zhurakousky commented

Artem, I am going to move this to M2 for several reasons.
Looking at this JIRA it seems like there was a minor bug that Mark fixed. What you did falls in the category of New Features and therefore should have its own JIRA. So I would suggest to actually resolve this one, open a new one and link them together.
Since its a new feature we have to give it a little more time for review and considering that we are approaching the release we won't have enough time, so I hope you understand. On our end we recognized that we have to be more proactive in letting you know the schedule and we'll do it next time.
Cheers

[spring-operator]

Artem Bilan commented

Current issue will be closed by Oleg's comment and with Mark's solution.